[Master] Patch missing type shapes #16154
Conversation
|
!ci-build-me |
dkijania
changed the title
buildkite/src/Lib/Cmds.dhall
Outdated
| { image : Text | ||
| , extraEnv : List Text | ||
| , privileged : Bool | ||
| , useBash : Bool |
There was a problem hiding this comment.
This appears to be unused in this PR, and generally orthogonal to the changes. Can you remove this?
| # RunInToolchain.runInToolchain | ||
| ([] : List Text) | ||
| "buildkite/scripts/version-linter.sh ${release_branch}" | ||
| , label = "Versioned type linter for ${release_branch}" | ||
| , key = "version-linter-${release_branch}" | ||
| , soft_fail = Some soft_fail |
There was a problem hiding this comment.
Issues with merging. Removing
| let Docker = ../../Command/Docker/Type.dhall | ||
|
|
||
| let Size = ../../Command/Size.dhall | ||
|
|
||
| let RunInToolchain = ../../Command/RunInToolchain.dhall |
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
…n dump-mina-type-shape script
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
| @@ -20,3 +20,5 @@ export TYPE_SHAPE_FILE=${MINA_COMMIT_SHA1}-type_shape.txt | |||
|
|
|||
| echo "--- Create type shapes git note for commit: ${MINA_COMMIT_SHA1}" | |||
| mina internal dump-type-shapes > ${TYPE_SHAPE_FILE} | |||
|
|
|||
| source buildkite/scripts/gsutil-upload.sh ${TYPE_SHAPE_FILE} gs://mina-type-shapes | |||
There was a problem hiding this comment.
We did an effort recently to setup agents in a way that now env vars which allows to correctly setup gsutil are passed to toolchain and allow us to upload file to gs directly from toolchain. Previously we had to ran gsutil directly from agent which was a bit of dance (dumping file on toolchains, then uploading on agents level).
In VersionLinter.dhall i removed line with upload to gcloud bucket
|
!ci-build-me |
scripts/version-linter.py
Outdated
| ''' | ||
| return requests.head(url).status_code == 200 | ||
|
|
||
| def find_latest_type_shape_ref_on(branch): |
There was a problem hiding this comment.
This function is redundant now that latest_branch_commit only returns 1 commit. Recommend deleting this and the helper functions
|
!ci-build-me |
|
!ci-build-me |
…nafly_master' into dkijania/generate_version_lint_inafly_master
|
!ci-build-me |
|
!ci-build-me |
This reverts commit 484dd949cf7b6012ffc7a7712ca286e0dfe0e50f.
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
|
!approved-for-mainnet |
When there is a missing reference file we can checkout missing commit , dump type shape and continue compairsion